Feature/remove user/soft removal #1691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Question: is deleting from Django admin the same than deleting from "Account" drop down button? |
Closed
No. Removing the Django admin only remove / anonymize the user personal data. It is only one of the step involved in the whole process. But note that is does not remove the user completly, it soft removes it. Also I'll do some changes to include the email sent to the admins and the confirmation email sent to the user for all cases. |
Should I wait for a commit from you before reviewing this PR then? Or is it already ready? |
Yes, wait for my modifications You will be able to review this PR after my next push |
…thod + update email and log in mechanism
…ompetition management view
OhMaley
force-pushed
the
feature/remove-user/soft-removal
branch
from
58c70ad to
ef95a38
Compare
Didayolo
changed the base branch from
develop
to
feature/remove-user/soft-removal
26 tasks
Didayolo
added a commit
that referenced
this pull request
Dec 23, 2024
* add soft deletions attributes in profile class + override deletion method + update email and log in mechanism * add emails template + soft delete + account view + deletion confirmation view * move the notice emails in the delete method of user * filter deleted users out of the front page stat * disable the action buttons on the list of participants modal in the competition management view Co-authored-by: Tristan Mary <[email protected]>
Didayolo
added a commit
that referenced
this pull request
Jan 16, 2025
* Update version.json for release 1.15.0 (#1712) * Merge develop into master (#1405) * organization oidc login added * unused test file removed * http client * some changes * oidc login and signup added * oidc flow completed * Prevent LimitOverrunError with large output lines If a submission writes a output line larger than the stream buffer size ( default 64k ) a LimitOverrunError will be raise. Rather than using readline(...) use readutil(....) and in the case of a overrun just return the current buffer, the rest of the line will be returned with the next read. Signed-off-by: Chris Harris <[email protected]> * terms and condition check added * one terms checkbox for all organization login buttons * removed sandbox property from iframe to allow links in the iframe * Detailed results title removed * Detailed results configuration (#1374) * competition model updated * competition settings to allow participant to make submission public/private * unwanted restriction removed * detailed results now shown in submission panel and in leaderboard * submission tests updated --------- Signed-off-by: Chris Harris <[email protected]> Co-authored-by: Ihsan Ullah <[email protected]> Co-authored-by: Chris Harris <[email protected]> * Revert "Merge develop into master (#1405)" This reverts commit a26fc36. * More general exception in views.py (#1512) * More general exception in views.py * Update views.py * Update version.json for release 1.15.0 --------- Signed-off-by: Chris Harris <[email protected]> Co-authored-by: Adrien Pavão <[email protected]> Co-authored-by: Ihsan Ullah <[email protected]> Co-authored-by: Ihsan Ullah <[email protected]> Co-authored-by: Benjamin Bearce <[email protected]> Co-authored-by: Chris Harris <[email protected]> Co-authored-by: Nicolas Homberg <[email protected]> Co-authored-by: GitHub Actions <[email protected]> * Feature/remove user/soft removal (#1691) (#1716) * add soft deletions attributes in profile class + override deletion method + update email and log in mechanism * add emails template + soft delete + account view + deletion confirmation view * move the notice emails in the delete method of user * filter deleted users out of the front page stat * disable the action buttons on the list of participants modal in the competition management view Co-authored-by: Tristan Mary <[email protected]> * Updated the filters to show the new "Is Deleted" (#1717) * Updated the filters to show the new "Is Deleted" * Flake8 fixes --------- Co-authored-by: Obada Haddad <[email protected]> * .gitingore update to ignore the home page counters file. Also removed the file from cache so that it's not tracked anymore * Fix/remove user/soft removal (#1724) * Set is_active to False when deleting a user * change the email sending method and populate the missing txt files * add a checkbox to show/hide deleted users in the list of participant modal * Fixed the wrong user being named in the greetings in the email sent to admins upon account deletion * Flake8 fixed * restricted the usage of deletion link more than one time, used a different deletion token to expire it after deletion, account deletion modal now disappears after clickin the delete my account button --------- Co-authored-by: OhMaley <[email protected]> Co-authored-by: Obada Haddad <[email protected]> Co-authored-by: Ihsan Ullah <[email protected]> * Fix URLs in user deletion email (#1729) * Fix URLs in user deletion email * Fix domain --------- Signed-off-by: Chris Harris <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Ihsan Ullah <[email protected]> Co-authored-by: Ihsan Ullah <[email protected]> Co-authored-by: Benjamin Bearce <[email protected]> Co-authored-by: Chris Harris <[email protected]> Co-authored-by: Nicolas Homberg <[email protected]> Co-authored-by: GitHub Actions <[email protected]> Co-authored-by: Tristan Mary <[email protected]> Co-authored-by: Obada Haddad-Soussac <[email protected]> Co-authored-by: Obada Haddad <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A brief description of the purpose of the changes contained in this PR.
This implement a full process to allow user's to remove their account automatically.
It includes:
Issues this PR resolves
#1159
A checklist for hand testing
Checklist